AA-340: Update the RIP-7560 with the EIP-7702 transaction type fields #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
reviewed
May 28, 2024
| @@ -217,10 +225,20 @@ struct TransactionType4 { | |||
| bytes paymasterData; | |||
| bytes callData; | |||
| bytes signature; | |||
| address[] authorizationList; | |||
| bool[] authorizationListStatus; | |||
There was a problem hiding this comment.
maybe better to provide authorizedList and failedAuthorizationList (which is expected to be empty)
There was a problem hiding this comment.
Just talked to @shahafn about that - we could not see how would it make it better? Appears to provide the exact same information (except, maybe, losing the ordering - which might even be a downside in some edge-cases) and not improving anything.
I prefer the bool[] approach.
forshtat
changed the title
sm-stack
reviewed
Jun 10, 2024
RIPS/rip-7560.md
Outdated
| @@ -61,7 +61,7 @@ smart contracts. This, however, is impossible without an addition of Native Acco | |||
| | Name | Value | | |||
| |-----------------------|---------------------------------------------------------------------------------| | |||
| | FORK_BLOCK | TBD | | |||
| | AA_TX_TYPE | 4 | | |||
| | AA_TX_TYPE | 126 | | |||
There was a problem hiding this comment.
I'm afraid that 126 is a deposit tx type at Optimism. Relative docs at optimism specs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.