Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added URL type import #60

Merged
merged 1 commit into from
Dec 30, 2020
Merged

added URL type import #60

merged 1 commit into from
Dec 30, 2020

Conversation

nriin-brainer
Copy link
Contributor

I am using this same fix on my own project. I'm not sure if this the perfect way to fix this issue, but let me know what you guys think. Thanks!

@nriin-brainer nriin-brainer marked this pull request as ready for review December 30, 2020 04:21
@ethanent ethanent merged commit 545c98d into ethanent:master Dec 30, 2020
@ethanent
Copy link
Owner

LGTM, thanks!

@nriin-brainer
Copy link
Contributor Author

i think this PR should resolve issue #58, is it not @ethanent?

@johanneswuerbach
Copy link

@ethanent any chance this fix could be released to npm? That would be great 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nriin-brainer @ethanent @johanneswuerbach