Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response body type for parse: none #64

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

jdforsythe
Copy link
Contributor

Fixes # 62

Fix response body type for parse: none to be Buffer
Add parse: string to explicitly ask for body as a string
Add types for string parsing
Add tests for Buffer and string bodies
Regenerate documentation

Fixes # 62

Fix response body type for parse: none to be Buffer
Add parse: string to explicitly ask for body as a string
Add types for string parsing
Add tests for Buffer and string bodies
Regenerate documentation
@jdforsythe
Copy link
Contributor Author

@ethanent This should not break any existing usages because the body type when using parse: 'none' was already coming back as a Buffer.

@ethanent ethanent merged commit 5987ef1 into ethanent:master Mar 2, 2021
@ethanent
Copy link
Owner

ethanent commented Mar 2, 2021

Thank you very much.

@jdforsythe jdforsythe deleted the 62-response-body-type branch March 2, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants