Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All consul commands use proper exit codes #1

Closed
ethanrowe opened this issue May 23, 2014 · 0 comments
Closed

All consul commands use proper exit codes #1

ethanrowe opened this issue May 23, 2014 · 0 comments
Assignees

Comments

@ethanrowe
Copy link
Owner

All existing commands should have meaningful exit codes:

  • 0 for normal exit
  • non-zero for non-standard exit

The heartbeat should probably exit with 255 if the agent isn't running (meaning it can't get information with the consul info call), and 0 otherwise.

The runner should probably exit with consul's exit code if consul exits with non-zero status. And otherwise exit with 0.

@ethanrowe ethanrowe self-assigned this May 24, 2014
@ethanrowe ethanrowe mentioned this issue May 30, 2014
ethanrowe added a commit that referenced this issue May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant