Set the document body color too #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if something has changed, but current version of themes isn't setting document body color correctly. Mirrored setBgColor to the working setFontColor to set the document background color using the innerdocbody inside the 2-deep iframe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
John,
Thanks for the excellent plugin! I noticed that the theme isn't updating the background-color of the document body in my version of Etherpad nor on the current test server of Etherpad so I figure something must've changed with the html. This simple patch should fix the issue so that the background color is changed in the document body too.
Mirrored setBgColor to the working setFontColor to set the document background color using the innerdocbody inside the 2-deep iframe.