Changeset: Add new Builder.prototype.build() method

ether · Oct 19, 2021 · 6d7a54e · 6d7a54e
1 parent fa1dac7
commit 6d7a54e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/node/utils/padDiff.js b/src/node/utils/padDiff.js
@@ -456,9 +456,7 @@ PadDiff.prototype._createDeletionChangeset = function (cs, startAText, apool) {
     }
   }
 
-  const packed = builder.toString();
-  Changeset.unpack(packed).validate();
-  return packed;
+  return builder.build().validate().toString();
 };
 
 // export the constructor

diff --git a/src/static/js/Changeset.js b/src/static/js/Changeset.js
@@ -1970,13 +1970,20 @@ exports.Builder = class {
     return this;
   }
 
-  toString() {
+  /**
+   * @returns {Changeset}
+   */
+  build() {
     let lengthChange;
     const serializedOps = exports.serializeOps((function* () {
       lengthChange = yield* exports.canonicalizeOps(this._ops, true);
     }).call(this));
     const newLen = this._oldLen + lengthChange;
-    return new Changeset(this._oldLen, newLen, serializedOps, this._charBank).toString();
+    return new Changeset(this._oldLen, newLen, serializedOps, this._charBank);
+  }
+
+  toString() {
+    return this.build().toString();
   }
 };
 
@@ -2195,9 +2202,7 @@ exports.inverse = (cs, lines, alines, pool) => {
     }
   }
 
-  const packed = builder.toString();
-  Changeset.unpack(packed).validate();
-  return packed;
+  return builder.build().validate().toString();
 };
 
 // %CLIENT FILE ENDS HERE%