Add call to account status endpoint before attempting to login to fix authentication. #38
Conversation
|
Will need to update the releases.rst just to ensure it passes the Hass PR requirements. |
I figured the release/update to the library would be a different PR - I can bounce the numbers to 0.6.5 in this PR if it's preferred. |
I suspect that an additional test for 'Must first check account status' should be included within https://github.com/etheralm/libpurecool/blob/master/tests/test_dyson_account.py:TestDysonAccount |
libpurecool/dyson.py
Outdated
| @@ -54,7 +54,7 @@ def login(self): | |||
| "dyson are using a self signed certificate.") | |||
|
|
|||
| #Must first check account status | |||
| accountstatus = requests.get(f"https://{self._dyson_api_url}/v1/userregistration/userstatus?country={self._country}&email={self._email}") | |||
| accountstatus = requests.get(f"https://{self._dyson_api_url}/v1/userregistration/userstatus?country={self._country}&email={self._email}", verify=False) | |||
There was a problem hiding this comment.
When I go to this URL I get cloudflare warning but the SSL certificate is valid. Are they redirecting away from cloudflare or something?
|
Can we get this merged and a release being published sometime soon? I think home-assistant users are waiting eagerly for this (home-assistant/core#46400). Thank you! |
Hopefully! I need to get the tests to pass but once I've done that it shouldn't be too difficult - however I wouldn't expect a merge here -- I'll probably end up having to publish it under another name on pypi (any ideas?) for now since I am willing to at least attempt to keep the library functional. |
Possibly - that said I don't think etheralm is particularly interested in merging & maintaining anymore
No, though I may just publish my fork to pypi and PR hass to move over. :/ |
This PR is based on the information form @shenxn here: #37 (comment)
I am also validating the account status in this to avoid unnecessary API calls to Dyson.