Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and add getter for slave alias address #213

Merged

Conversation

jbbjarnason
Copy link
Contributor

Add getter for slave alias addresses

@jamwaffles
Copy link
Collaborator

Hey, thanks for the PR! I'm a bit busy with other things, but I'll review it when I have a moment. I'll need to rerun the replay tests capture but that's fine (and also only something I can do unfortunately) to make the CI pass.

Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a couple of changes and a changelog entry on top of your original commit - hope you don't mind! Thanks again for the original PR! I'll cut a release with this method in it asap.

@jamwaffles jamwaffles merged commit 238f487 into ethercrab-rs:master May 27, 2024
8 checks passed
@jamwaffles
Copy link
Collaborator

0.4.2 is out - please cargo update :)

@jbbjarnason jbbjarnason deleted the add-getter-for-alias-address branch May 27, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants