New field tx_type

[coccoinomane]

Hi there!

Did you ever consider to add a tx_type field to differentiate between chains implementing EIP-1559 (tx_type=2) and those who don't (tx_type=1)?

It would be very useful for clients who need to send transactions on the chains, for example my project web3cli.

I am willing to make a PR if there's consensus on it 🙂

Cheers,
Cocco

[ligi]

Yes - this is a good idea - I considered it but did not yet find a good way to define it. IMHO it should be more universal than just tx type.
Was then thinking something like

"features": ["EIP1559",..]

but then also realized we might need transition points (blocks?)

[coccoinomane]

Why not something like this?

  "features": [
    {
      "name": "EIP1559",
      "since_block": 123,
      ...
    },
    ...
  ]

If needed, we can always add extra properties to 'feature' at a later time, without compromising backward compatibility.

[ligi]

yea - sometimes it might not be a block - but maybe this is enough for the MVP

[coccoinomane]

Thanks @ligi for the quick commit!

I have made a pull request adding the EIP1559 feature to Avalanche 🙂