This repository has been archived by the owner on Apr 11, 2021. It is now read-only.
[Feat] Use rawTransaction #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlfloersch
commented
Mar 10, 2021
karlfloersch
commented
Mar 10, 2021
|
TODO: update package.json to use new provider once merged |
annieke
reviewed
Mar 12, 2021
annieke
force-pushed
the
feat/use_raw_transaction
branch
from
52d3c19
to
08d9461
Compare
karlfloersch
commented
Mar 15, 2021
annieke
force-pushed
the
feat/use_raw_transaction
branch
from
d034e60
to
79b016a
Compare
karlfloersch
commented
Mar 15, 2021
| @@ -21,3 +21,10 @@ export const remove0x = (str: string): string => { | |||
| return str | |||
| } | |||
| } | |||
|
|
|||
| export const formatNumber = (num: any): number => { | |||
There was a problem hiding this comment.
Should this be num: string?
Is there a function which does this in core-utils? If not I think it's fine to include here but eventually probably a good idea to move it there
There was a problem hiding this comment.
i copied this from ethers formatter, which i think is supposed to keep the input general since it may begin as a number too
i'll move it into core-utils in a followup PR :)
karlfloersch
added a commit
that referenced
this pull request
Mar 22, 2021
This reverts commit d4de023.
karlfloersch
added a commit
that referenced
this pull request
Mar 22, 2021
This was referenced Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses https://github.com/ethereum-optimism/roadmap/issues/757
Make the batch submitter use
rawTransactioninstead of doing crazy encoding.