Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: update standard version to v1.6.0, CGT to v2.0.0-beta.3 #895

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

bitwiseguy
Copy link
Contributor

@bitwiseguy bitwiseguy commented Sep 12, 2024

Description

The recommended monorepo contracts tag/release is now v1.6.0.

The recommended monorepo contracts tag for CustomGasToken is now v2.0.0-beta.3

Tests

No tests added. Just changed some text.

@bitwiseguy bitwiseguy requested a review from a team as a code owner September 12, 2024 13:58
Copy link
Contributor

coderabbitai bot commented Sep 12, 2024

Walkthrough

The changes in this pull request update the recommended release versions for deploying Layer 1 (L1) smart contracts and custom gas tokens. The documentation now advises users to utilize the "Fault Proof Fixes release" version 1.6.0 instead of the previously recommended "Multi-Chain Prep (MCP) L1 release" version 1.3.0. Additionally, references to the custom gas token feature have been updated from version v2.0.0-beta.2 to v2.0.0-beta.3. These updates aim to guide users toward the most appropriate contract releases for effective operation.

Changes

File Path Change Summary
pages/builders/chain-operators/deploy/smart-contracts.mdx Updated deployment recommendation from Multi-Chain Prep (MCP) L1 release (v1.3.0) to Fault Proof Fixes release (v1.6.0)
pages/builders/chain-operators/features/custom-gas-token.mdx Updated version references from v2.0.0-beta.2 to v2.0.0-beta.3 in documentation.
pages/stack/smart-contracts.mdx Updated recommended release version for new production chains from op-contracts/v1.3.0 to op-contracts/v1.6.0.

Possibly related issues

Possibly related PRs

  • minor updates for l1 contract deployments #810: This PR updates the documentation for deploying OP Stack L1 smart contracts, which is directly related to the changes in this PR that also focuses on deployment recommendations for L1 contracts.

Suggested labels

documentation


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit ff196f8
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/66e30192dd9e7300087ce9a8
😎 Deploy Preview https://deploy-preview-895--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sbvegan sbvegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, with the fault proof rollout we're also suggesting a staggered approach at the moment. Starting permissioned gives chain operators some breathing room to learn how to run the new economics and infrastructure requirements in a safe environment. Switching to permissionless is just a configuration change away at that point.

pages/builders/chain-operators/deploy/smart-contracts.mdx Outdated Show resolved Hide resolved
@bitwiseguy bitwiseguy changed the title contracts: update recommended deploy version to v1.6.0 contracts: update standard version to v1.6.0, CGT to v2.0.0-beta.3 Sep 12, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
pages/builders/chain-operators/features/custom-gas-token.mdx (1)

21-21: Rephrase the sentence for better clarity.

The version update to v2.0.0-beta.3 looks good.

To improve clarity, consider rephrasing the sentence to start with a verb or insert a comma:

-  *   Checkout the [`v2.0.0-beta.3` of the contracts](https://github.com/ethereum-optimism/optimism/tree/op-contracts/v2.0.0-beta.3) and use the commit to deploy.
+  *   Check out [`v2.0.0-beta.3` of the contracts](https://github.com/ethereum-optimism/optimism/tree/op-contracts/v2.0.0-beta.3), and use the commit to deploy.
Tools
LanguageTool

[grammar] ~21-~21: This sentence should probably be started with a verb instead of the noun ‘Checkout’. If not, consider inserting a comma for better clarity.
Context: ...> ### Deploying Your Contracts * Checkout the [v2.0.0-beta.3 of the contracts](...

(SENT_START_NN_DT)

pages/stack/smart-contracts.mdx (1)

40-40: Looks good! Just a minor suggestion.

The change accurately updates the recommended contract release version for new production chains to op-contracts/v1.6.0. This ensures that the documentation reflects the latest preferred version for deployment.

To maintain consistency in communal documentation, consider using proper nouns like "Optimism" in place of personal pronouns like "we":

-  Note: While these are a governance approved contract release, the recommended
+  Note: While these are a governance approved contract release, the recommended
-  release for new production chains is `op-contracts/v1.6.0`.
+  release for new production chains on Optimism is `op-contracts/v1.6.0`.
Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3770dd4 and ff196f8.

Files selected for processing (3)
  • pages/builders/chain-operators/deploy/smart-contracts.mdx (1 hunks)
  • pages/builders/chain-operators/features/custom-gas-token.mdx (2 hunks)
  • pages/stack/smart-contracts.mdx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • pages/builders/chain-operators/deploy/smart-contracts.mdx
Additional context used
Path-based instructions (2)
pages/builders/chain-operators/features/custom-gas-token.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
pages/stack/smart-contracts.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
LanguageTool
pages/builders/chain-operators/features/custom-gas-token.mdx

[grammar] ~21-~21: This sentence should probably be started with a verb instead of the noun ‘Checkout’. If not, consider inserting a comma for better clarity.
Context: ...> ### Deploying Your Contracts * Checkout the [v2.0.0-beta.3 of the contracts](...

(SENT_START_NN_DT)

Additional comments not posted (1)
pages/builders/chain-operators/features/custom-gas-token.mdx (1)

50-50: LGTM!

The version update to v2.0.0-beta.3 is accurate.

Copy link
Collaborator

@sbvegan sbvegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for your help here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants