Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: pipeline deriver wrapper #10962

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Jun 20, 2024

Description

This introduces a wrapper around derivation pipeline (the L1 data -> L2 block attributes conversion process), to step/reset based on events, and return back the status with events.

This does not change the usage of the derivation pipeline in the op-program yet; that can be done together with the other changes in #10947

Tests

Derivation usage is covered in almost every e2e system/action test. The wrapper around the derivation pipeline basically just maps inputs/outputs to pipeline calls to events, little point in unit-testing when it already runs through the same in e2e action tests.

Metadata

Fix #10957

@protolambda protolambda changed the title work in progress pipeline deriver wrapper op-node: work in progress pipeline deriver wrapper Jun 20, 2024
@protolambda protolambda marked this pull request as ready for review June 20, 2024 04:25
@protolambda protolambda requested review from ajsutton and a team as code owners June 20, 2024 04:25
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@protolambda protolambda changed the title op-node: work in progress pipeline deriver wrapper op-node: pipeline deriver wrapper Jun 20, 2024
@protolambda protolambda added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 72d57dc Jun 20, 2024
58 checks passed
@protolambda protolambda deleted the derivation-pipeline-events branch June 20, 2024 06:29
rdovgan pushed a commit to rdovgan/optimism that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop: instrument Pipeline with events
2 participants