add p2p.sync.onlyreqtostatic flag to p2p flags
#11011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiangxu
force-pushed
the
only_req_to_static
branch
3 times, most recently
from
b26db71
to
95325d9
Compare
zhiqiangxu
force-pushed
the
only_req_to_static
branch
from
95325d9
to
26f03a6
Compare
protolambda
reviewed
Jun 28, 2024
protolambda
approved these changes
Jun 29, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Jun 29, 2024
4a525b5
60 checks passed
blockchaindevsh
pushed a commit
to blockchaindevsh/optimism
that referenced
this pull request
Jul 10, 2024
…1011) * add p2p.sync.onlyreqtostatic flag to p2p flags * fix for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
p2p.sync.onlyreqtostaticflag to op-node so that when enabled,RequestL2Rangewill only forward requests to static peers.This is handy for new nodes to increase the success rate for
checkForGapInUnsafeQueue, otherwise it often happens that bad peers received the request(peers race to handle the request by receiving frompeerRequestschannel) and thus report "failed to check for unsafe L2 blocks to sync".This flag is especially useful for opstack instances with large batcher submit interval(e.g, 12h).
(The big flag diff is caused by goformat, only a new flag
SyncOnlyReqToStaticNamewas added)