Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-chain-ops: check-migration-quick #5589

Merged
merged 1 commit into from
May 3, 2023
Merged

op-chain-ops: check-migration-quick #5589

merged 1 commit into from
May 3, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented May 3, 2023 •
edited
Loading

Description

Adds a new tool that can be used as part of the migration that checks a minimal amount of information to ensure that the database migration was successful. It checks the extradata in the block header for the bedrock magic and errors if its not found. It will log information about the block header as well.

Closes CLI-3915

A clear and concise description of the features you're adding in this pull request.

@tynes
op-chain-ops: check-migration-quick
dbb9204 
Adds a new tool that can be used as part of the migration that checks
a minimal amount of information to ensure that the database migration
was successful. It checks the extradata in the block header for the
bedrock magic and errors if its not found. It will log information
about the block header as well.
@tynes tynes requested a review from a team as a code owner May 3, 2023 17:29
@tynes tynes requested a review from ajsutton May 3, 2023 17:29
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: dbb9204

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 3, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit dbb9204
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645299ece274470008a68706

trianglesphere
trianglesphere approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OptimismBot OptimismBot merged commit 6d134fc into develop May 3, 2023
@OptimismBot OptimismBot deleted the feat/check-migration-quick branch May 3, 2023 18:17
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trianglesphere trianglesphere trianglesphere approved these changes

@ajsutton ajsutton Awaiting requested review from ajsutton ajsutton was automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tynes @trianglesphere @OptimismBot