Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code fixes how we calculate the error rate.
tl;dr it adds a tolerance in which the error rate will be set to 0 until we have at least 10 data points.
When the sliding window has few data points, the error rate can be skewed quickly, causing the node to the banned. I.e. for an max error rate of 50%, it takes 1 error out of 2 requests to ban the node.
Also when the window is empty, it was previously causing an division by zero.
Tests
Manual
Invariants
n/a
Additional context
Original PR: #5542
This change is part of the Consensus Aware RPC Proxy: https://www.notion.so/oplabs/Consensus-Aware-RPC-Proxy-0138e029af814e4cbca2740c7888e02d
Metadata
TODOs