Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-proposer): Missing CheckRequired Invocation #5635

Merged
merged 2 commits into from
May 8, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 8, 2023

Description

Following pr #5634, I found the op-proposer was missing the CheckRequired flags check at the beginning of the main l2 output submitter function.

I believe it should follow the batch submitter logic.

@refcell refcell requested a review from a team as a code owner May 8, 2023 13:04
@refcell refcell requested a review from Inphi May 8, 2023 13:04
@refcell refcell self-assigned this May 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

⚠️ No Changeset found

Latest commit: a3acacf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit a3acacf
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64590e4e3b4e60000840fa84

@refcell refcell changed the title fix: Proposer missing flag requires checks fix(op-proposer): Missing CheckRequired Invocation May 8, 2023
@tynes
Copy link
Contributor

tynes commented May 8, 2023

This generally looks right to me

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit bdefad7 into develop May 8, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the refcell/fix/proposer branch May 8, 2023 15:15
@mergify mergify bot removed the on-merge-train label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants