Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-chain-ops: cleanup default gas limit #6430

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jul 25, 2023

Description

Use a single default value for when configuring the genesis value of the block gas limit for both L1 and L2 when it is not set in the deploy config. The value defaults to 30 million when it is not explicitly set.

This PR is slowly moving changes out of #6123 into their own smaller PRs so that they can be merged in independently of the final functionality.

Use a single default value for when configuring the genesis
value of the block gas limit for both L1 and L2 when it is not
set in the deploy config. The value defaults to 30 million when
it is not explicitly set.

This PR is slowly moving changes out of #6123
into their own smaller PRs so that they can be merged in independently
of the final functionality.
@tynes tynes requested a review from a team as a code owner July 25, 2023 02:02
@tynes tynes requested a review from protolambda July 25, 2023 02:02
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

⚠️ No Changeset found

Latest commit: 494d517

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 494d517
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64bf30b7e4b8970007d5638d

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #6430 (494d517) into develop (a19535e) will increase coverage by 3.27%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6430      +/-   ##
===========================================
+ Coverage    40.58%   43.86%   +3.27%     
===========================================
  Files          464      312     -152     
  Lines        33378    24857    -8521     
  Branches      1949        0    -1949     
===========================================
- Hits         13546    10903    -2643     
+ Misses       18356    12947    -5409     
+ Partials      1476     1007     -469     
Flag Coverage Δ
bedrock-go-tests 43.86% <50.00%> (+<0.01%) ⬆️
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
op-chain-ops/genesis/layer_one.go 74.74% <0.00%> (ø)
op-chain-ops/genesis/genesis.go 86.20% <100.00%> (ø)

... and 153 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 0ecda15 into develop Jul 25, 2023
12 checks passed
@OptimismBot OptimismBot deleted the feat/cleanup-default-gaslimit branch July 25, 2023 02:53
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants