-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: Span Batch Type, Encoding, and Decoding #7288
op-node: Span Batch Type, Encoding, and Decoding #7288
Conversation
Hey @ImTei! This PR has merge conflicts. Please fix them before continuing review. |
ba71953
to
d74f634
Compare
Adding a do-not-merge label to give others the chance to review before auto-merge by mergify kicks in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are some stylistic but breaking things I think we can do in a follow-up PR, after the PR stack is wrapped up.
Define SpanBatch and related types Rename BatchV1 to SingularBatch Add unit test cases
Fix comments Check if the span batch is empty in LogContext() Check chain ID of the protected tx in newSpanBatchTxs() Write SpanBatchType explicitly when encoding span batch
1b4e3e7
to
23c658d
Compare
applied simple changes from code reviews and rebased to the latest develop branch. Other suggestions will be applied in the follow-up PR! |
Follow-ups to implement in later PR:
And opened #7615 to fix a blocking issue: we must not allow span-batches to be decoded successfully before the HF, or we diverge from the actual mainnet specs. |
454c525
into
ethereum-optimism:develop
Contexts
This PR contains the type, encoding, and decoding code for Span Batch as defined specs.
Please refer to the Encoding Optimization section in Design Docs for the rationale behind the current encoding specs.
This PR has a dependency on the Hardfork Configuration PR.
Changes
Type
section of Implementation Design Docs for details.Data Structure
category in the Test List Sheet for each test’s details.