Removes Living toggling between review and living. #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe we decided in a previous EIPs meeting to just have Living stay living. Having it toggle to review doesn't make sense, because then it means there is no living EIP-1 while it is in review.
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): @MicahZoltu @lightclient @Arachnid @cdetrio @Souptacular @vbuterin @nicksavers @wanderer @gcolvin @axic |
axic
approved these changes
Sep 7, 2021
|
I suppose so. Thanks! |
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
I believe we decided in a previous EIPs meeting to just have Living stay living. Having it toggle to review doesn't make sense, because then it means there is no living EIP-1 while it is in review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we decided in a previous EIPs meeting to just have Living stay living. Having it toggle to review doesn't make sense, because then it means there is no living EIP-1 while it is in review.
cc @poojaranjan