Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-5169: Add contributing author #184

Closed
wants to merge 1 commit into from
Closed

Update ERC-5169: Add contributing author #184

wants to merge 1 commit into from

Conversation

JamesSmartCell
Copy link
Contributor

This PR is to add an author who contributed to the original concept.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 4, 2024 •
edited
Loading

File ERCS/erc-5169.md

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @SamWilsn

@eip-review-bot eip-review-bot changed the title Add contributing author Update ERC-5169: Add contributing author Jan 4, 2024
xinbenlv
xinbenlv approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@xinbenlv xinbenlv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing lead author wants to add another author, I don't seem obvious concern

@xinbenlv xinbenlv enabled auto-merge (squash) January 8, 2024 16:24
@xinbenlv xinbenlv marked this pull request as draft January 8, 2024 16:25
auto-merge was automatically disabled January 8, 2024 16:25

Pull request was converted to draft

@xinbenlv xinbenlv marked this pull request as ready for review January 8, 2024 16:25
@poojaranjan poojaranjan mentioned this pull request Jan 9, 2024
Closed
17 tasks
SamWilsn
SamWilsn requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is final, so we should probably do a Call for Input.

@SamWilsn SamWilsn mentioned this pull request Jan 9, 2024
Closed
@SamWilsn
Copy link
Collaborator

SamWilsn commented Feb 9, 2024

As discussed on ethcatherders/EIPIP#308, the prevailing opinion among editors is to not modify a final proposal.

@SamWilsn SamWilsn closed this Feb 9, 2024
@poojaranjan poojaranjan mentioned this pull request Feb 15, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn requested changes

@xinbenlv xinbenlv xinbenlv approved these changes

@eip-review-bot eip-review-bot Awaiting requested review from eip-review-bot eip-review-bot is a code owner

Assignees
No one assigned
Labels
c-update e-consensus s-final t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesSmartCell @eip-review-bot @SamWilsn @xinbenlv