Update ERC-1363: Remove external links and useless references #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
eip-review-bot
changed the title
This was referenced Oct 31, 2023
9 tasks
…ve-erc1363-to-eip1-recommendation-2step
…ve-erc1363-to-eip1-recommendation-2step
11 tasks
…ve-erc1363-to-eip1-recommendation-2step
…ve-erc1363-to-eip1-recommendation-2step
…ve-erc1363-to-eip1-recommendation-2step
7 tasks
|
The commit 3e34d42 (as a parent of a4ba678) contains errors. |
|
These changes are a bit more involved than we allow for final EIPs. I think the best option would be to open a new EIP with the updated content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of some changes I would like to make on ERC1363 to follow the modern EIP1 recommendation.
This PR:
Note that this PR will not pass the CI, because of many changes required by validator and that are not addressed here but will be addressed in other PR.
I.g. external links, broken link, new line after h1, etc.
Other PR will address other sections of ERC1363