Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-7535: Move to Review #78

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update ERC-7535: Move to Review #78

merged 1 commit into from
Nov 28, 2023

Conversation

Joeysantoro
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 31, 2023 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Move ERC-7535 to Review Update ERC-7535: Move to Review Oct 31, 2023
@Joeysantoro Joeysantoro mentioned this pull request Oct 31, 2023
Closed
26 tasks
@github-actions GitHub Actions
Copy link

The commit e885843 (as a parent of f0a6894) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Oct 31, 2023
@poojaranjan poojaranjan mentioned this pull request Oct 31, 2023
Closed
19 tasks
@poojaranjan poojaranjan mentioned this pull request Nov 14, 2023
Closed
19 tasks
@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

SamWilsn
SamWilsn approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update your branch to get past HTMLProofer.

@eip-review-bot eip-review-bot enabled auto-merge (squash) November 28, 2023 15:29
eip-review-bot
eip-review-bot approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 707bc79 into ethereum:master Nov 28, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eip-review-bot eip-review-bot eip-review-bot approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

Assignees
No one assigned
Labels
c-status e-review s-review t-erc w-ci w-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joeysantoro @eip-review-bot @SamWilsn