This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Fixes related to GCC9 #5798
Merged
Fixes related to GCC9 #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of C++11, the implicitly declared copy constructor is deprecated if a class has user-defined assignment operator. GCC 9 has added a warning for it.
If strncpy() is used the requested count of characters must be lower than the destination buffer. Otherwise in the edge case the result string will not have the null terminator. This change fixes the issue by making the "max path" constant 1 char smaller.
This was referenced Oct 28, 2019
Merged
Codecov Report
@@ Coverage Diff @@
## master #5798 +/- ##
==========================================
- Coverage 64.03% 64.03% -0.01%
==========================================
Files 359 359
Lines 30774 30774
Branches 3416 3416
==========================================
- Hits 19706 19705 -1
Misses 9845 9845
- Partials 1223 1224 +1 |
|
Thanks. It compiles now on Arch Linux and gcc 9.2.0 |
gumb0
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read commits descriptions.
Fixes #5637.
Fixes #5795.