Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting nasty linker errors in Lighthouse due to different versions of the
blst
library being linked by:crypto/bls
: our BLS wrapper that depends on theblst
crate fromcrates.io
.c_kzg/c_kzg_min
: mainnet/minimal variants of c-kzg which depend on their ownlibblst.a
which is built at compile-time.As well as causing link errors when the
blst
versions get out of sync, the current setup also wastes compilation time by compilingblst
3 times.I think the changes in this PR improve the situation by using a single copy of
blst
throughout. Due to thelinks
attribute inblst
'sCargo.toml
, Cargo will now error if we try to compile with multiple copies of theblst
crate. We can also make semver-compatible updates toblst
downstream without having to bump theblst
version inc-kzg
, so long as the headers are compatible with the ones vendored inc-kzg
.