Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more targets to ci #390

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Feb 3, 2024

Adds aarch64 targets to the rust CI alongside x86_86, including for macOS, using the new M1 runner. Also fixes an issue where rust-cache would not find bindings/rust/Cargo.toml due to the workspace field being unset.

@Rjected
Copy link
Contributor Author

Rjected commented Feb 3, 2024

note: will probably remove the linux arm workflow as the benchmarks are ridiculously slow for some reason

@jtraglia
Copy link
Member

jtraglia commented Feb 5, 2024

Looks good, but wow yeah let's remove the linux aarch64 workflow. That's ridiculously slow. The first run was 39 minutes. Re-ran it again and it was 41 minutes. Not sure why it's so slow.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jtraglia jtraglia merged commit 5efe8d0 into ethereum:main Feb 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants