Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nim] Add completeStruct pragma which workarounds Nim compiler's issue with C codegen. #437

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cheatfate
Copy link
Contributor

@cheatfate cheatfate commented Jun 12, 2024

This helps to avoid Nim codegen issues when KZG types become parts of pure Nim objects.
PR works for both pre-gcc-14 and gcc-14.

@cheatfate cheatfate changed the title Add completeStruct pragma which workarounds Nim compiler's issue with C codegen. [nim] Add completeStruct pragma which workarounds Nim compiler's issue with C codegen. Jun 12, 2024
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks @cheatfate!

@jtraglia jtraglia merged commit b175a27 into ethereum:main Jun 13, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants