Strict ValidatorIndex definition
#1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of the given list, not `ValidatorIndex`
mratsim
reviewed
Apr 9, 2020
| @@ -722,24 +722,24 @@ def is_valid_merkle_branch(leaf: Bytes32, branch: Sequence[Bytes32], depth: uint | |||
| #### `compute_shuffled_index` | |||
|
|
|||
| ```python | |||
| def compute_shuffled_index(index: ValidatorIndex, index_count: uint64, seed: Bytes32) -> ValidatorIndex: | |||
| def compute_shuffled_index(index: uint64, index_count: uint64, seed: Bytes32) -> uint64: | |||
There was a problem hiding this comment.
Maybe the input param should be renamed offset as further differentiation?
djrtwo
approved these changes
Apr 14, 2020
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We defined that
ValidatorIndexis the index number forstate.validators.By that definition, the input parameter
indexincompute_shuffled_indexis the position of theindex_count-sizeSequence[ValidatorIndex], notValidatorIndex.I found it by looking at the line
assert index < index_countsince IMO it's wrong if the givenindexis really aValidatorIndex.How did I fix it
This PR only removes the wrong type casting, no substantive change for PySpec, but I'm not sure about how other client implementations deal with casting.