Add tests of processing objects of N-2 fork version
#2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
force-pushed
the
fork-version-tests
branch
from
9acfa23
to
b3ef9b2
Compare
djrtwo
reviewed
Aug 18, 2022
| ) | ||
|
|
||
|
|
||
| def _run_voluntary_exit_processing_with_specific_fork_version( |
There was a problem hiding this comment.
The name seems slightly off given that this is specifically for an epoch in the previous signature domain (epoch 0, and a fork at epoch 1). that said, it doesn' matter too too much.
There was a problem hiding this comment.
to make the name more apt and add a couple of tests -- maybe a bool here -- is_before_fork_epoch -- that says if you utilize a voluntary exit with an epoch pre or post the most recent state.fork.epoch. Then we could write a test that has Altair fork_Version but for after fork.epoch which should fail (and a bellatrix fork_version for before the bellatrix fork)
There was a problem hiding this comment.
good suggestion 👍 added the new bool flag in 6c00b48
tests/core/pyspec/eth2spec/test/bellatrix/block_processing/test_process_deposit.py
Outdated
Show resolved
Hide resolved
tests/core/pyspec/eth2spec/test/bellatrix/block_processing/test_process_deposit.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
…t_process_deposit.py Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
djrtwo
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_process_voluntary_exit.pytest_voluntary_exit_with_previous_fork_version__valid:ALTAIR_FORK_VERSIONtest_voluntary_exit_with_genesis_fork_version__invalid:GENESIS_FORK_VERSIONtest_process_deposit.pyGENESIS_FORK_VERSIONcan add new entryrun_voluntary_exit_processingandrun_deposit_processingfunction to the shared helper files.