-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/hysteresis on active validator #3045
base: dev
Are you sure you want to change the base?
Fix/hysteresis on active validator #3045
Conversation
While this is an edgecase affecting a desired functionality for your application, I think it unlikely that this is altered (especially soon) given (1) the functionality of 1 ETH deposits was designed for "top-ups" rather than iterative deposits and (2) that the desired functionality can be achieved trivially through the use of a smart contract on the execution layer. Given (2) and the design goal of simplicity in CL, my personal preference is to leave as is and to put a warning in the validator guide. Note: This cannot just be changed in Phase 0 (as specified). It might be changed in a subsequent spec and hard fork. If this is to be entertained for a future hard fork, I suggest putting this in it's own spec folder (e.g. |
- duplicating epoch_processing test to make sure things still work
It would be easier for a new protocol for the change and it is a big impact for us. But agreed and we have the same expectation and working on the infrastructure upgrade to fix it.
Agreed. Definitely good to put warning to prevent this from happening again. Could also put the stuck validators as example that there's case would need 33 ETH to activate a validator.
Right, made sense. I have moved that into a separate folder as suggested. Thank you for the feedback. |
Please note it was added in phrase 0 with all tests pass before moving into sub folder. |
Skipping hysteresis on pending validator