Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift all fork choice tests to Altair & later #3294

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

adiasg
Copy link
Contributor

@adiasg adiasg commented Mar 15, 2023

#3290 changes on_tick to update Store in a way that is not expected in Phase 0. When clients run test vectors, they have to resort to hacking their test runner to skip certain (all?) fork choice tests from Phase 0.

This PR moves all fork choice tests to Altair and later, removing the need for a hacky test runner.

@adiasg adiasg requested a review from hwwhww March 15, 2023 23:42
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I checked with pytest --disable-bls eth2spec/test/phase0/fork_choice --fork=phase0.

@hwwhww hwwhww merged commit 3ee5a2b into dev Mar 15, 2023
@hwwhww hwwhww deleted the fork-choice-change-test-phase branch March 15, 2023 23:53
@adiasg
Copy link
Contributor Author

adiasg commented Mar 16, 2023

Fork choice test vectors for 5a21760:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants