Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Electra (EIP6110 + EIP7002) #3615

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Init Electra (EIP6110 + EIP7002) #3615

merged 8 commits into from
Apr 9, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 6, 2024

Merged EIP6110 and EIP7002 specs into new Electra specs.

/cc @djrtwo


## Containers

### New containers

#### `DepositReceipt`

*Note*: The container is new in EIP6110.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note can be inferred from

 deposit_receipts: List[DepositReceipt, MAX_DEPOSIT_RECEIPTS_PER_PAYLOAD]  # [New in Electra:EIP6110]`

not sure if it's worth the percent and now we may have to annotate all containers

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a couple of nits!

fork.md still refers to EIP-6110: "This document describes the process of EIP-6110 upgrade.” (couldn’t make a proper link to this line)

specs/electra/beacon-chain.md Outdated Show resolved Hide resolved
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@StefanBratanov
Copy link
Contributor

I raised a small PR #3629 for an EIP-6110 function rename. I am not sure if a comment here would have been more appropriate.

@hwwhww hwwhww mentioned this pull request Mar 26, 2024
Copy link
Contributor

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@hwwhww hwwhww marked this pull request as ready for review April 4, 2024 22:11
presets/mainnet/electra.yaml Outdated Show resolved Hide resolved
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
@hwwhww hwwhww merged commit aba6345 into dev Apr 9, 2024
28 of 29 checks passed
@hwwhww hwwhww deleted the init-electra branch April 9, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants