Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename shard_block_root -> crosslink_data_root #662

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Rename shard_block_root -> crosslink_data_root #662

merged 3 commits into from
Feb 22, 2019

Conversation

vbuterin
Copy link
Contributor

No description provided.

@JustinDrake
Copy link
Collaborator

Brainstorming: crosslink_hash, crosslink_root, crosslink_commitment, shard_commitment

@vbuterin
Copy link
Contributor Author

Or data_root or shard_data_root.

@JustinDrake
Copy link
Collaborator

Or shard_root or shard_hash.

@vbuterin
Copy link
Contributor Author

I like the word "data" in there; it reminds the reader that it has something to do with the data in a shard, as opposed to various other shard-related things (eg. state)

@JustinDrake
Copy link
Collaborator

I like the word "shard" or "crosslink" in there to differentiate from beacon-related things. What about crosslink_data_root?

@vbuterin
Copy link
Contributor Author

Sure :)

djrtwo
djrtwo approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed this change through the validator and phase 1 doc.

@djrtwo djrtwo changed the title Rename shard_block_root -> shard_data_commitment Rename shard_block_root -> crosslink_data_root Feb 22, 2019
@djrtwo djrtwo merged commit 06e6496 into dev Feb 22, 2019
@djrtwo djrtwo deleted the vbuterin-patch-5 branch February 22, 2019 15:51
@hwwhww hwwhww mentioned this pull request Feb 25, 2019
Closed
@terencechain terencechain mentioned this pull request Feb 25, 2019
Closed
@terencechain terencechain mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbuterin @JustinDrake @djrtwo