Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_deltas functions should return Tuple instead of List #996

Merged
merged 1 commit into from
Apr 26, 2019
Merged

_deltas functions should return Tuple instead of List #996

merged 1 commit into from
Apr 26, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 25, 2019

No description provided.

@JustinDrake
Copy link
Collaborator

Can we use a tool to find these automatically?

@djrtwo
Copy link
Contributor

djrtwo commented Apr 26, 2019

You can run mypy/a linter on the output pyspec file but probably not on the markdown

@djrtwo djrtwo changed the base branch from dev to master April 26, 2019 13:55
djrtwo
djrtwo approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed base to master

@JustinDrake JustinDrake mentioned this pull request Apr 26, 2019
Closed
@djrtwo djrtwo merged commit b69423f into master Apr 26, 2019
@djrtwo djrtwo deleted the return_tuple branch April 26, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hwwhww @JustinDrake @djrtwo