Add API methods to ABIType for web3 #118
Conversation
|
@pipermerriam I suppose this part of eth-abi could maybe use a documentation update. Since we're going to pull it into web3.py, it's starting to look like public API but I don't think there's any section in the docs for it. I'd like to address that in a separate issue ticket if possible so it doesn't block the related web3 work for too long. |
|
I'm fine with docs happening separately but they should happen asap so we don't forget. |
tests/test_grammar.py
Outdated
| ) | ||
| def test_abi_type_item_type(type_str): | ||
| abi_type = parse(type_str) | ||
| assert not abi_type.has_dynamic_arrlist |
There was a problem hiding this comment.
This test looks repeated. Based on the name, maybe it was supposed to test something else?
eth_abi/grammar.py
Outdated
| raise NotImplementedError('Must implement `is_dynamic`') | ||
|
|
||
| @property | ||
| def has_dynamic_arrlist(self): |
There was a problem hiding this comment.
Does has_dynamic_arrlist need to be public? Seems like it's mostly a helper property, so my instinct is to _-prefix it until we know we want to use it somewhere.
What was wrong?
Web3.py still uses the deprecated
process_typefunction which assumes all type strings are terminal types (non-tuple types).How was it fixed?
This PR adds some API features to the AST classes whose instances are output by eth-abi's new parsing facilities. These new API features can then be utilized in web3.py to remove the old
process_typefunction.Cute Animal Picture