Pull in recent template updates #44
Conversation
Skip venv in template filler & print progress
Add MANIFEST.in file
Some hard-coded references to web3.py slipped through. Clearly this user path is not tested very often. In eth-abi, it still said EthereumAlarmClock X)
…n-docs Replace web3 reference with <MODULE_NAME>
…-and-lint-deps Update testing and lint deps
Better error if bump missing in make notes/release
Latest mypy refuses package with file path
It has weird capitalization rules, in particular.
Collection of updates
…itions Add IDE filenames to .gitignore
pacrob
force-pushed
the
upgrade-template
branch
from
6fe32f9
to
5bfb89a
Compare
pacrob
force-pushed
the
upgrade-template
branch
2 times, most recently
from
9b4784f
to
a7f7305
Compare
docs/eth_typing.rst
Outdated
There was a problem hiding this comment.
I figured out why this file was there, lol. This file gets auto-generated every time make docs is run. So we can either: a) figure out how to stop that, b) remember to delete it each time make docs is run, or c) just leave it committed so we don't have to worry about it. Option a is probably the "correct" answer, but I think c is almost as good in the short term.
There was a problem hiding this comment.
The sphinx-apidoc command won't overwrite existing files unless you force it to. So I just renamed types.rst to eth_typing.rst and changed reference name in index.rst. It looks like it's working fine to me.
There was a problem hiding this comment.
yay! Thanks for figuring that out!!
pacrob
force-pushed
the
upgrade-template
branch
2 times, most recently
from
5d2d10b
to
6fb566b
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
6fb566b
to
38a41fb
Compare
pacrob
force-pushed
the
upgrade-template
branch
13 times, most recently
from
0e0030c
to
29222b8
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
29222b8
to
b2776b0
Compare
There was a problem hiding this comment.
Thank you for all of these! I left a few comments, but they're the same as the other comments I left in eth-abi and py-ssz, so I think they actually belong in the template update you've got going on.
I'm getting the same doc warning that I mentioned somewhere else too: WARNING: html_static_path entry '_static' does not exist.
.gitignore
Outdated
|
|
||
| # mpeltonen/sbt-idea plugin | ||
| ### mpeltonen/sbt-idea plugin |
There was a problem hiding this comment.
Same nit from somewhere else: I think this is covered on line 86.
| showcontent = true |
There was a problem hiding this comment.
I think we also need a deprecation category here.
What was wrong?
The project template was recently updated. This PR pulls in those updates.
How was it fixed?
Template update process
Cute Animal Picture