Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to Sync Network Constants #51

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Oct 18, 2023

What was wrong?

Related to Issue
ethereum/eth-typing#253

How was it fixed?

Script to rewrite the networks.py file with the newest networks.

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa requested review from fselmo and pacrob October 18, 2023 20:39
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. lgtm 👍🏼

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@reedsa reedsa merged commit 7c9021b into ethereum:master Oct 19, 2023
19 checks passed
@reedsa reedsa deleted the network-script branch October 19, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants