Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0 release #2082

Merged
merged 76 commits into from
Nov 4, 2020
Merged

v1.0 release #2082

merged 76 commits into from
Nov 4, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Sep 28, 2020 •
edited
Loading

ralexstokes and others added 15 commits September 11, 2020 17:08
@ralexstokes
Update p2p-interface.md
3cb1580 
Typo fixes
@protolambda
Use gossip signing policy in p2p spec, see libp2p/specs#294
8ad0865
@protolambda
Merge pull request #2077 from ethereum/master
7a46181 
re-enable ssz_static mainnet tests
@ericsson49
use integer division (//) instead of non-integer (/)
104b83a
@djrtwo
Merge pull request #2078 from ericsson49/ericsson49/fix_compute_weak_…
d7cb570 
…subjectivity_period

`compute_weak_subjectivity_period` should use integer division (//)
@djrtwo
revert incorrect type fix
a232efb
@djrtwo
Merge pull request #2054 from ethereum/ralexstokes-patch-1
8c9c943 
Typos in: p2p-interface.md
@protolambda
cleanup phase1 TOC contents
7088274
@djrtwo
Merge pull request #2079 from ethereum/toc-cleanup
6a1813b 
cleanup phase1 TOC contents
@hwwhww
Add IETF BLS draft 04 edge cases test vectors
19d6c83
@hwwhww
Aggregate G2 point at infinity
bdbd2aa
@hwwhww
Bump IETF BLS spec version draft 03 -> draft 04
ad4ad2d
@hwwhww
Fix encoding
b43f62d
@protolambda
update signature policy link
62d596a
@djrtwo
upgrade config to mainnet values
157f7e8
djrtwo and others added 13 commits September 28, 2020 17:55
@djrtwo
add additional genesis initialization tests
4e2c7d2
@djrtwo
use better rng practice for reproducibility
76d6926
@djrtwo
fix function signature calls on deposit helpers
0e2e494
@djrtwo
PR feedback. thanks @hwwhww
9f36fd6
@djrtwo
Merge pull request #2083 from ethereum/init-tests
122d34a 
additional genesis init tests
@hwwhww
Bump py_ecc to 5.0.0
4613c6b
@djrtwo
Merge pull request #2060 from protolambda/signing-policy
5f9e659 
Use gossip signing policy in p2p spec, see libp2p/specs#294
@hwwhww
Bump milagro_bls_binding to 1.4.0, handle the exception cases
4d3ac72
@hwwhww
Merge pull request #2080 from ethereum/bls_v4
d264ad8 
Bump IETF BLS spec version draft 03 -> draft 04
@hwwhww
Bump milagro_bls_binding to 1.5.0
00a19e5
@djrtwo
Merge pull request #2087 from ethereum/bls_v4_milagro_patch
29b5efd 
Bump milagro_bls_binding to 1.5.0
@djrtwo
fix test generators for mainnet max slashing penalties
2e09c91
@djrtwo
Merge pull request #2088 from ethereum/fix-test
df23a95 
Fix mainnet test for test generators
@JustinDrake JustinDrake self-requested a review November 4, 2020 15:07
JustinDrake
JustinDrake approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@JustinDrake JustinDrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

benjaminion
benjaminion approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@benjaminion benjaminion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (On behalf of the Teku crew)

CarlBeek
CarlBeek approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

protolambda
protolambda approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for launch

Edit: for those watching, we are updating some notes here and there to better reflect mainnet.

@djrtwo djrtwo force-pushed the v1.0-candidate branch 3 times, most recently from 2a44f17 to 368863c Compare November 4, 2020 15:25
@terencechain
Copy link
Contributor

LGTM (On behalf of the Prysm crew)

@ethereum ethereum deleted a comment from ymonye Nov 4, 2020
@protolambda
Copy link
Collaborator

Moderation comment: feedback welcome, but keep meme comments for the after party, not the final straws

wemeetagain
wemeetagain approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🚀 on behalf of the Lodestar team

@fabiotongson
Copy link

Awesome work 🚀🚀🚀

@djrtwo djrtwo merged commit 579da6d into master Nov 4, 2020
@DogeCornHub
Copy link

Here for the future screenshots

@Akif-G
Copy link

Akif-G commented Nov 4, 2020

Great Job!

@paulmillr
Copy link

Hell yeah.

@AlexMasmej
Copy link

History made :)

@djrtwo djrtwo deleted the v1.0-candidate branch November 4, 2020 16:24
@terencechain terencechain mentioned this pull request Nov 4, 2020
Merged
@rune20
Copy link

rune20 commented Nov 4, 2020

Here for the historical moment! LFG!

@pinkhoodie
Copy link

This is incredible. Congrats everyone 🥳

@nftleader
Copy link

Incredible! Hurray! 👍🏻

@BenjellounO
Copy link

Well done everyone!! such an incredible milestone achieved right here and High 5 to all of the engineers and researchers who have worked on this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@CarlBeek CarlBeek CarlBeek approved these changes

@protolambda protolambda protolambda approved these changes

@benjaminion benjaminion benjaminion approved these changes

@melyalex melyalex melyalex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.