Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keepers to the Documentation [Fixes #4477] #4698

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Add Keepers to the Documentation [Fixes #4477] #4698

merged 3 commits into from
Dec 17, 2021

Conversation

andrejrakic
Copy link
Contributor

Added explanation of Keepers to the Oracle Documentation Page

Description

  • Explained what Keepers are and why there is a need for them
  • Explained the usage of Chainlink Keepers by providing a code sample
  • Listed Chainlink Keepers and Keep3r Network as notable projects so far

Related Issue

A related issue is #4477

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Dec 9, 2021
minimalsm
minimalsm requested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrejrakic, thanks for the PR. Just done an initial pass and made some suggestions re: readability.

src/content/developers/docs/oracles/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/oracles/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/oracles/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/oracles/index.md Outdated Show resolved Hide resolved
@minimalsm
Copy link
Contributor

This is looking good :-) just waiting on another pair of eyes to check it out.

As raised by @samajammin in the original issue some work could be done to make this more neutral—we definitely don't want to appear to be saying that Chainlink is the only company providing this sort of service. However, I don't think that burden is on you and think it is something we can iterate on internally.

samajammin
samajammin approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@minimalsm
Copy link
Contributor

Bringing this in! Thanks for the work on this @andrejrakic ❤️

Be sure to claim your POAP also 🥳!

@minimalsm
Copy link
Contributor

@all-contributors please add @andrejrakic for docs, content

@allcontributors allcontributors bot mentioned this pull request Dec 17, 2021
Merged
@allcontributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @andrejrakic! 🎉

@minimalsm minimalsm merged commit d39bf3d into ethereum:dev Dec 17, 2021
@andrejrakic
Copy link
Contributor Author

Thanks @minimalsm it was my pleasure!

@andrejrakic andrejrakic deleted the keepers branch December 17, 2021 17:12
@wackerow wackerow mentioned this pull request Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@samajammin samajammin samajammin approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

Assignees

@andrejrakic andrejrakic

Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrejrakic @minimalsm @samajammin