Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DocLink component #4807

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Refactor DocLink component #4807

merged 3 commits into from
Dec 20, 2021

Conversation

wackerow
Copy link
Member

Description

  • Change DocLink to take the title as a child to the component
  • Allows using as block component within markdown by splitting syntax over three lines
  • Updates all usage of this component with new syntax

pass `title` as a child instead. destructuring.
adds strings to json
Split over three lines when using within markdown to use `block` positioning
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Dec 16, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 16, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

Performance

Lighthouse report

Metric Score
Performance 🔶 21
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

@minimalsm minimalsm merged commit 02a5ed7 into dev Dec 20, 2021
@minimalsm minimalsm deleted the doclink-refactor branch December 20, 2021 15:13
@wackerow wackerow mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants