Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#946 - Fixes for small configuration bugs found by tests #967

Merged
merged 3 commits into from
Jun 14, 2018
Merged

#946 - Fixes for small configuration bugs found by tests #967

merged 3 commits into from
Jun 14, 2018

Conversation

weisheme
Copy link
Contributor

@weisheme weisheme commented Dec 3, 2017

Could you please confirm that my reasoning is correct and that my bug fix is what you expected?

  1. No longer accept nodes where the hostname cannot be resolved through InetAddress.getByName() even when
    a hostIpPattern = null (wildcard) was provided.
  2. Now accepts any InetAddress when hostIpPattern = null (wildcard)
  3. Only accept provided privateKey when it's Hex encoded

@weisheme weisheme force-pushed the issue_946 branch 2 times, most recently from ee6be58 to 16320b1 Compare December 10, 2017 10:39
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 59.903% when pulling 16320b1 on weisheme:issue_946 into bca8b0e on ethereum:develop.

@mkalinin
Copy link
Contributor

Should resolve #963

@mkalinin
Copy link
Contributor

@Nashatyrev please, take a look

@Nashatyrev
Copy link
Member

Sounds reasonable

@mkalinin
Copy link
Contributor

@weisheme could you pls stick your branch with develop?

@mkalinin mkalinin merged commit c887e11 into ethereum:develop Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weisheme @coveralls @mkalinin @Nashatyrev