cpp: Add vm::get_capabilities() method #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
approved these changes
May 29, 2019
axic
reviewed
May 29, 2019
| * | ||
| * The value returned might change when different options are requested via set_option. | ||
| * The value returned MAY change when different options are set via the set_option() method. |
There was a problem hiding this comment.
Is there a way we could add a test for this? Does it make sense to add a test for this?
There was a problem hiding this comment.
We could add behavior like that to example_vm but there is nothing to test here about conformance. Anyway, I'm going to remove this "feature" in EVMC 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #265.