Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade doxygen to 1.9.4 #650

Merged
merged 2 commits into from
May 27, 2022
Merged

Upgrade doxygen to 1.9.4 #650

merged 2 commits into from
May 27, 2022

Conversation

chfast
Copy link
Member

@chfast chfast commented May 26, 2022

This fixes an issue with one from_hex() overload in #649.

@chfast chfast requested a review from axic May 26, 2022 12:30
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #650 (cbd5fdf) into master (4b1dbad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          23       23           
  Lines        3546     3546           
  Branches      375      375           
=======================================
  Hits         3293     3293           
  Misses        144      144           
  Partials      109      109           

LATEX_HIDE_INDICES = NO
LATEX_SOURCE_CODE = NO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed completely.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, four deprecated entries were removed by the tool. Previously warnings about these were emitted.

RTF_EXTENSIONS_FILE =
RTF_SOURCE_CODE = NO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed completely.

DOCBOOK_OUTPUT = docbook
DOCBOOK_PROGRAMLISTING = NO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

#---------------------------------------------------------------------------
# Configuration options related to the dot tool
#---------------------------------------------------------------------------
CLASS_DIAGRAMS = NO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Doxyfile Outdated
# Possible values are: NO, YES, TEXT and GRAPH.
# The default value is: YES.

CLASS_GRAPH = TEXT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed from YES to TEXT.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to YES to get the graph:
image
But previously we had:
image

So the upgrade tool was right to change it to TEXT. Considering this is the biggest class hierarchy we have, I will change it back to TEXT.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I want to go back to previous version. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with either option.

The doxygen config has been upgraded to 1.9.4 version with doxygen -u.
@chfast chfast merged commit 118166f into master May 27, 2022
@chfast chfast deleted the doxygen branch May 27, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants