Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test utils #31

Merged
merged 9 commits into from
May 6, 2019
Merged

Test utils #31

merged 9 commits into from
May 6, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented May 6, 2019

Closes #30

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #31 into master will increase coverage by 2.65%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   84.98%   87.64%   +2.65%     
==========================================
  Files           8        9       +1     
  Lines        1585     1586       +1     
  Branches      149      145       -4     
==========================================
+ Hits         1347     1390      +43     
+ Misses        159      120      -39     
+ Partials       79       76       -3

@@ -10,6 +10,37 @@
#include <iomanip>
#include <iostream>

bytes from_hex(std::string_view hex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be an OK idea moving this to evmc so it can also be used in Hera?

Or perhaps creating yet another library? :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure... I'd rather copy&paste sources...

@chfast chfast merged commit 3168ed7 into master May 6, 2019
@chfast chfast deleted the testutils branch May 6, 2019 14:57
jwasinger pushed a commit to jwasinger/evmone that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve from_hex()
3 participants