-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate long compilation time of long byteocode with solc --evm-version shanghai
#148
Comments
This had nothing to do with solc or its compilation time. This long delay was triggered when The delay appears to rather occur in pytest and is probably due to the large and complicated diff that pytest performs on the two very long byte arrays. Indeed, the delay was only visible when pytest was ran with |
* tools: update framemwork tests to run with solc v0.8.{20,21} * docs: update required solc versions * chore: test solc 0.8.20 and 0.8.21 in ci/cd * chore: fix test_yul with large bytecode test case cf #148 * tools/tests: use `packaging.version` --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
Upon using a newer version of solc and compiling the "long bytecode" test with
--evm-version=shanghai
, the test took much longer to complete - it actually looked like it had completely hanged. But it does terminate, cf #147.The text was updated successfully, but these errors were encountered: