Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add EIP-1153 loop until out-of-gas tests #401

Merged
merged 4 commits into from
Jan 25, 2024
Merged

tests: Add EIP-1153 loop until out-of-gas tests #401

merged 4 commits into from
Jan 25, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 24, 2024 •
edited

🗒️ Description

Adds several test cases where the contract runs TSTORE and TLOAD continuously to different keys until it runs out of gas.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the type:test Type: Test label Jan 24, 2024
@marioevz marioevz changed the title tests: EIP-1153 loop until out-of-gas tests tests: Add EIP-1153 loop until out-of-gas tests Jan 24, 2024
danceratopz
danceratopz approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/CHANGELOG.md Outdated Show resolved Hide resolved
danceratopz
danceratopz reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a thought to help ensure correct test behavior.

tests/cancun/eip1153_tstore/test_tstorage.py Show resolved Hide resolved
@danceratopz danceratopz added the type:feat type: Feature label Jan 25, 2024
marioevz and others added 2 commits January 25, 2024 10:13
@marioevz marioevz mentioned this pull request Jan 25, 2024
Open
@marioevz marioevz merged commit e2b84cc into ethereum:main Jan 25, 2024
5 checks passed
@marioevz marioevz deleted the more-tstore-tload-cases branch January 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega left review comments

@danceratopz danceratopz danceratopz approved these changes

Assignees
No one assigned
Labels
type:feat type: Feature type:test Type: Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marioevz @winsvega @danceratopz