Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): dynamic create2 collision from different transactions same block #430

Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat(tests): dynamic create2 collision from different transactions same block #430

merged 1 commit into from
Feb 9, 2024

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Feb 8, 2024 •
edited
Loading

🗒️ Description

dynamic create2 collision from different transactions same block

🔗 Related Issues

#381

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or evm version 1.13.11-unstable-765f2904-20240124
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega added scope:pytest Scope: Pytest plugins scope:tests Scope: Test cases labels Feb 8, 2024
@winsvega winsvega force-pushed the create2col branch 2 times, most recently from 13411ea to ba95e28 Compare February 8, 2024 20:37
marioevz
marioevz approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

tests/cancun/eip6780_selfdestruct/test_dynamic_create2_selfdestruct_collision.py Outdated Show resolved Hide resolved
@marioevz marioevz merged commit 04f9b1b into main Feb 9, 2024
9 checks passed
@marioevz marioevz deleted the create2col branch February 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:pytest Scope: Pytest plugins scope:tests Scope: Test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winsvega @marioevz