Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully implement expression mapping #21

Closed
2 of 11 tasks
g-r-a-n-t opened this issue Sep 11, 2020 · 1 comment
Closed
2 of 11 tasks

Fully implement expression mapping #21

g-r-a-n-t opened this issue Sep 11, 2020 · 1 comment
Labels
comp: compiler type: feature

Comments

@g-r-a-n-t
Copy link
Member

g-r-a-n-t commented Sep 11, 2020 •
edited by cburgdorf
Loading

The following expressions need to be mapped to Yul:

  • Ternary
  • BoolOperation
  • BinOperation
  • UnaryOperation
  • CompOperation
  • Call
  • List
  • ListComp
  • Tuple
  • Str
  • Ellipsis

Attempting to compile a contract that includes one of these expressions will give rise to an unimplemented error.

Todo:
Replace each branch in this statement with an appropriate call to a new mapping function that returns an ExtExpression result.
@g-r-a-n-t g-r-a-n-t mentioned this issue Sep 14, 2020
Closed
4 tasks
@sbillig
Copy link
Collaborator

sbillig commented May 7, 2021

Ellipsis and ListComp have been cut (but could be revived later, if needed); the rest have been implemented.

@sbillig sbillig closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: compiler type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbillig @g-r-a-n-t