-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usize and isize primitive types #1012
add usize and isize primitive types #1012
Conversation
Hey @Y-Nak lmk if it looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review.
LGTM overall. I left some minor nits.
I'll merge this PR when these nits are addressed.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keywords defined by the define_keywords
macro are const
values.
So it'd be better to keep the upper case names. Other fixes are great!
@Y-Nak got it, left the keywords in capitals |
Thank you! |
What was done?
Added
usize
andisize
types. Solves #995