Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect discv5::enr::NodeId in NodeInfo repsonse #139

Closed
wants to merge 1 commit into from

Conversation

mrferris
Copy link
Collaborator

Due to a change in ethportal_api, trin's representation of a NodeId in a NodeInfo response changed.

This happening in the future will be avoided once #138 is merged

@mrferris
Copy link
Collaborator Author

mrferris commented Jun 30, 2023

On second thought, this violates the portal spec, which for this node ID field reads:

description: Hex encoded NodeId of an ENR (a 32 byte identifier).
pattern: ^0x[0-9a-f]{64}$

whereas discv5::enr::NodeId is serializing to an array of bytes.

So the change should be trin-side.

@mrferris mrferris closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant