core, les: clean up tx journal file after testing #15521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested changes
Nov 21, 2017
There was a problem hiding this comment.
Instead of creating and then deleting the journal, why not simply not create in the first place?
Instead of using core.DefaultTxPoolConfig as the tx pool configuration, make a copy of it, and set the Journal field to the empty string. Then no journal will be created.
rjl493456442
force-pushed
the
clean_tx_journal
branch
from
fd889c9
to
41ef34a
Compare
|
@karalabe Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After les package testing, a tx journal file will be created. This file should be cleaned